prototype CIM<->PCP bridge
Review Request #458 - Created June 15, 2013 and submitted
| Information | |
|---|---|
| Frank Eigler | |
| openlmi-providers | |
| Reviewers | |
| developers | |
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
smoke-testing via YAWN web gui
Posted (June 17, 2013, 9:25 a.m.)
The mof and reg files are generated, right? We are trying to automate build as much as possible. It would be better to not include generated files in the source.
Posted (June 17, 2013, 9:29 a.m.)
Please see mof/README file in git, we have to prefix file names with numbers. Rather ship mof files with (in this case) 60_ prefix.
Review request changed
Updated (July 9, 2013, 2:09 a.m.)
Change Summary:
rebased on git openlmi-providers; now with integrated build/regeneration scripts
Diff: |
Revision 2 (+454 -3) |
|---|
Posted (July 9, 2013, 8:52 a.m.)
-
src/pcp/lmi/pcp/metric.py (Diff revision 2) -
Please add also description of the error, something like: raise pywbem.CIMError(pywbem.CIM_ERR_FAILED, "Unable to fetch data from PCP")
-
src/pcp/lmi/pcp/metric.py (Diff revision 2) -
"except" without defining the exception is considered bad habit in Python. It can easily hide programming mistakes and it even catches calling exit(). Please, specify which exceptions can occur
I don't consider these issues blockers, feel free to commit. Ask for the commit rights (gitcura group in fedora) if you don't have them. Or we can commit it for you.
Ship It!
Review request changed
Updated (July 10, 2013, 2:53 a.m.)
Change Summary:
v3, with python suggestions included, and /usr/bin/openlmi-pcp-generate reworked. I don't have commit privileges (yet?); would appreciate you committing it for me this time if appropriate.
Diff: |
Revision 3 (+465 -3) |
|---|